]> git.karo-electronics.de Git - linux-beck.git/commit
xen-netback: fix error handling output
authorArnd Bergmann <arnd@arndb.de>
Thu, 10 Nov 2016 08:55:42 +0000 (09:55 +0100)
committerJuergen Gross <jgross@suse.com>
Thu, 10 Nov 2016 08:55:42 +0000 (09:55 +0100)
commit0f06ac3b6616b9793b3fb5c398d94044a0423492
tree0e96c332df5a2214c75064a442f6a188a583a859
parent999c9af9e3a2535d9ad41182e93eb128e587eb84
xen-netback: fix error handling output

The connect function prints an unintialized error code after an
earlier initialization was removed:

drivers/net/xen-netback/xenbus.c: In function 'connect':
drivers/net/xen-netback/xenbus.c:938:3: error: 'err' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This prints it as -EINVAL instead, which seems to be the most
appropriate error code. Before the patch that caused the warning,
this would print a positive number returned by vsscanf() instead,
which is also wrong. We probably don't need a backport though,
as fixing the warning here should be sufficient.

Fixes: f95842e7a9f2 ("xen: make use of xenbus_read_unsigned() in xen-netback")
Fixes: 8d3d53b3e433 ("xen-netback: Add support for multiple queues")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/net/xen-netback/xenbus.c