]> git.karo-electronics.de Git - karo-tx-linux.git/commit
gpio/sx150x: Do not access I2C from mask/unmask functions
authorThomas Gleixner <tglx@linutronix.de>
Mon, 14 Feb 2011 17:08:51 +0000 (18:08 +0100)
committerGrant Likely <grant.likely@secretlab.ca>
Tue, 22 Feb 2011 21:59:53 +0000 (14:59 -0700)
commit0ff56cd85a2c5104a36d84662b9180c219e8604e
tree2d8826a9743143402a8028a3a1c36f21ff5df755
parent0b782531c038d4a4bded3fc1069c961b1f14f0de
gpio/sx150x: Do not access I2C from mask/unmask functions

irq_chip->irq_mask/unmask are called with interrupts disabled and
irq_desc->lock held. So we cannot access i2c from this context. That's
what irq_bus_sync_unlock() is for.

Store the masked information in the chip data structure and update the
i2c bus from the irq_bus_sync_unlock() callback.

This does not need a while(pending) loop because the update to this is
always serialized via the bus lock, so we never have more than one pin
update pending.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Gregory Bean <gbean@codeaurora.org>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Lennert Buytenhek <buytenh@secretlab.ca>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
drivers/gpio/sx150x.c