]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ext4: fix ext4_ext_direct_IO()'s return value after converting uninit extents
authorMingming <cmm@us.ibm.com>
Tue, 10 Nov 2009 15:48:08 +0000 (10:48 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 10 Nov 2009 15:48:08 +0000 (10:48 -0500)
commit109f55651954def97fa41ee71c464d268c512ab0
tree7c4aa2d8cb10c100bbd252e657ac410d30844bac
parentfa5d11133b07053270e18fa9c18560e66e79217e
ext4: fix ext4_ext_direct_IO()'s return value after converting uninit extents

After a direct I/O request covering an uninitalized extent (i.e.,
created using the fallocate system call) or a hole in a file, ext4
will convert the uninitialized extent so it is marked as initialized
by calling ext4_convert_unwritten_extents().  This function returns
zero on success.

This return value was getting returned by ext4_direct_IO(); however
the file system's direct_IO function is supposed to return the number
of bytes read or written on a success.  By returning zero, it confused
the direct I/O code into falling back to buffered I/O unnecessarily.

Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/extents.c
fs/ext4/inode.c