]> git.karo-electronics.de Git - karo-tx-linux.git/commit
include/log2.h: fix rounddown_pow_of_two(1)
authorAndrei Warkentin <andreiw@vmware.com>
Fri, 2 Dec 2011 03:12:12 +0000 (14:12 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 6 Dec 2011 04:05:30 +0000 (15:05 +1100)
commit13328629841181eb2b303fb9fe87b5660ff3bf74
treef50d12ca6a0ba381c94838d82311fcad475f55d7
parentaaf53d5ba16420f1cc90c7de1151ab449acae37e
include/log2.h: fix rounddown_pow_of_two(1)

1 is a power of two, therefore rounddown_pow_of_two(1) should return 1.
It does in case the argument is a variable but in case it's a constant it
behaves wrong and returns 0.  Probably nobody ever did it so this was
never noticed, however net/drivers/vmxnet3 with latest GCC does and breaks
on unicpu systems.

This is similar to Rolf's patch to roundup_pow_of_two(1).

Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>
Reviewed-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Andrei Warkentin <andreiw@vmware.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
include/linux/log2.h