]> git.karo-electronics.de Git - karo-tx-linux.git/commit
l2tp: Restore socket refcount when sendmsg succeeds
authorGuillaume Nault <g.nault@alphalink.fr>
Fri, 1 Mar 2013 05:02:02 +0000 (05:02 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Mar 2013 20:05:01 +0000 (13:05 -0700)
commit136d76de5b72b4a45eec80e4e5ee14f397aa1fed
tree80fb7a9d156401590fa78da5bc35d9ea80b8713c
parent0530082c3595511fa2bfc1434a5ad809e5ec90a3
l2tp: Restore socket refcount when sendmsg succeeds

[ Upstream commit 8b82547e33e85fc24d4d172a93c796de1fefa81a ]

The sendmsg() syscall handler for PPPoL2TP doesn't decrease the socket
reference counter after successful transmissions. Any successful
sendmsg() call from userspace will then increase the reference counter
forever, thus preventing the kernel's session and tunnel data from
being freed later on.

The problem only happens when writing directly on L2TP sockets.
PPP sockets attached to L2TP are unaffected as the PPP subsystem
uses pppol2tp_xmit() which symmetrically increase/decrease reference
counters.

This patch adds the missing call to sock_put() before returning from
pppol2tp_sendmsg().

Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/l2tp/l2tp_ppp.c