]> git.karo-electronics.de Git - linux-beck.git/commit
tpm, tpm_crb: fix unaligned read of the command buffer address
authorJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tue, 15 Sep 2015 17:05:40 +0000 (20:05 +0300)
committerPeter Huewe <peterhuewe@gmx.de>
Sun, 18 Oct 2015 23:01:03 +0000 (01:01 +0200)
commit149789ce9d472e6b4fd99336e779ab843754a96c
treeadd7cf2d84263432ab70892d83d9fe9ba2c00379
parent60ecd86c4d985750efa0ea3d8610972b09951715
tpm, tpm_crb: fix unaligned read of the command buffer address

The command buffer address must be read with exactly two 32-bit reads.
Otherwise, on some HW platforms, it seems that HW will abort the read
operation, which causes CPU to fill the read bytes with 1's. Therefore,
we cannot rely on memcpy_fromio() but must call ioread32() two times
instead.

Also, this matches the PC Client Platform TPM Profile specification,
which defines command buffer address with two 32-bit fields.

Cc: stable@kernel.org
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
drivers/char/tpm/tpm_crb.c