]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mm: pass correct mm when growing stack
authorHugh Dickins <hugh@veritas.com>
Thu, 16 Apr 2009 21:45:05 +0000 (21:45 +0000)
committerChris Wright <chrisw@sous-sol.org>
Mon, 27 Apr 2009 17:37:02 +0000 (10:37 -0700)
commit14be1689c96842bd93cbcda4cb0bd4c5cc15a5a0
treedb5c6ba307a25d3b8af9a98158d7d0891f18d4d9
parentd683876908060916ada0091d1db3b09afccb1517
mm: pass correct mm when growing stack

upstream commit: 05fa199d45c54a9bda7aa3ae6537253d6f097aa9

Tetsuo Handa reports seeing the WARN_ON(current->mm == NULL) in
security_vm_enough_memory(), when do_execve() is touching the
target mm's stack, to set up its args and environment.

Yes, a UMH_NO_WAIT or UMH_WAIT_PROC call_usermodehelper() spawns
an mm-less kernel thread to do the exec.  And in any case, that
vm_enough_memory check when growing stack ought to be done on the
target mm, not on the execer's mm (though apart from the warning,
it only makes a slight tweak to OVERCOMMIT_NEVER behaviour).

Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
mm/mmap.c