]> git.karo-electronics.de Git - karo-tx-linux.git/commit
firewire: ohci: fix TI TSB82AA2 regression since 2.6.35
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Sun, 17 Oct 2010 12:09:12 +0000 (14:09 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 29 Oct 2010 04:51:29 +0000 (21:51 -0700)
commit14d7e74a7f658fdd370e9a790b55e3b93eb259fc
treea5c3f5ba4c72b04a368015242f7e26cbda427110
parentfe17f612b3ea86e7af439432fc6b7d6d5e15d508
firewire: ohci: fix TI TSB82AA2 regression since 2.6.35

commit aa0170fff3c26bf2b42159af2dd9cf86444c292a upstream.

Revert commit 54672386ccf36ffa21d1de8e75624af83f9b0eeb
"firewire: ohci: fix up configuration of TI chips".
It caused massive slow-down and data corruption with a TSB82AA2 based
StarTech EC1394B2 ExpressCard and FireWire 800 harddisks.

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/657081
http://thread.gmane.org/gmane.linux.kernel.firewire.user/4013

The fact that some card EEPROMs do not program these enhancements may be
related to TSB81BA3 phy chip errata, if not to bugs of TSB82AA2 itself.
We could re-add these configuration steps, but only conditional on a
whitelist of cards on which these enhancements bring a proven positive
effect.

Reported-and-tested-by: Eric Shattow <lucent@gmail.com>
Cc: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/firewire/ohci.c
drivers/firewire/ohci.h