]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver
authorBrian Norris <computersforpeace@gmail.com>
Fri, 13 Jul 2012 16:28:24 +0000 (09:28 -0700)
committerArtem Bityutskiy <artem.bityutskiy@linux.intel.com>
Fri, 24 Aug 2012 08:03:37 +0000 (11:03 +0300)
commit14f44abf1dafc20ba42ce8616a8fc8fbd1b3712b
tree440ae350ccc83a646a06cfd04cd90438b1c30fb7
parentb654a9a46fc2100b318050483f8c5b5d0f187303
mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver

The NAND_CHIPOPTIONS_MSK has limited utility and is causing real bugs. It
silently masks off at least one flag that might be set by the driver
(NAND_NO_SUBPAGE_WRITE). This breaks the GPMI NAND driver and possibly
others.

Really, as long as driver writers exercise a small amount of care with
NAND_* options, this mask is not necessary at all; it was only here to
prevent certain options from accidentally being set by the driver. But the
original thought turns out to be a bad idea occasionally. Thus, kill it.

Note, this patch fixes some major gpmi-nand breakage.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Tested-by: Huang Shijie <shijie8@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
drivers/mtd/nand/nand_base.c
include/linux/mtd/nand.h