]> git.karo-electronics.de Git - karo-tx-linux.git/commit
PM: Free memory bitmaps if opening /dev/snapshot fails
authorMichal Kubecek <mkubecek@suse.cz>
Sat, 18 Jun 2011 18:34:01 +0000 (20:34 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 13 Jul 2011 03:29:24 +0000 (05:29 +0200)
commit1588e8230601e70f79743755c2e031392e6a9a53
tree2a1b33fa132972c890c23a218d2f264e16b8940a
parentddaa6a0bb301607d0e2a3c0414115a596a6f7c14
PM: Free memory bitmaps if opening /dev/snapshot fails

commit 8440f4b19494467883f8541b7aa28c7bbf6ac92b upstream.

When opening /dev/snapshot device, snapshot_open() creates memory
bitmaps which are freed in snapshot_release(). But if any of the
callbacks called by pm_notifier_call_chain() returns NOTIFY_BAD, open()
fails, snapshot_release() is never called and bitmaps are not freed.
Next attempt to open /dev/snapshot then triggers BUG_ON() check in
create_basic_memory_bitmaps(). This happens e.g. when vmwatchdog module
is active on s390x.

Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
kernel/power/user.c