]> git.karo-electronics.de Git - karo-tx-linux.git/commit
binfmt_elf: Uninitialized variable
authorAlan Cox <alan@linux.intel.com>
Fri, 28 Sep 2012 00:20:30 +0000 (10:20 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Fri, 5 Oct 2012 04:01:28 +0000 (14:01 +1000)
commit15f84b21164b255fcb0f1286bc8e805d362fbfd0
tree25bd6b51c3c510d25b4719b9887b12fa1c9694d2
parent021f4a4c22696121a6ea2ff0ec4677a80e0bfc60
binfmt_elf: Uninitialized variable

load_elf_interp() has interp_map_addr carefully described as
"uninitialized_var" and marked so as to avoid a warning.  However if you
trace the code it is passed into load_elf_interp and then this value is
checked against NULL.

As this return value isn't used this is actually safe but it freaks
various analysis tools that see un-initialized memory addresses being read
before their value is ever defined.

Set it to NULL as a matter of programming good taste if nothing else

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/binfmt_elf.c