]> git.karo-electronics.de Git - karo-tx-linux.git/commit
rc: fix ghost keypresses with certain hw
authorJarod Wilson <jarod@redhat.com>
Thu, 16 Jun 2011 19:18:37 +0000 (16:18 -0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sat, 9 Jul 2011 06:15:15 +0000 (23:15 -0700)
commit1601e4bd145b1309894cfe42c2de5795a01db4d8
treecc7e042ab71cfb7d4d1d4f73d7d493cb21791372
parenta8ece95dee741125ac6c20987bea46b2b346715c
rc: fix ghost keypresses with certain hw

commit 3f5c4c73322e4d6f3d40b697dac3073d2adffe41 upstream.

With hardware that has to use ir_raw_event_store_edge to collect IR
sample durations, we were not doing an event reset unless
IR_MAX_DURATION had passed. That's around 4 seconds. So if someone
presses up, then down, with less than 4 seconds in between, they'd get
the initial up, then up and down upon pressing down.

To fix this, I've lowered the "send a reset event" logic's threshold to
the input device's REP_DELAY (defaults to 500ms), and with an
saa7134-based GPIO-driven IR receiver in a Hauppauge HVR-1150, I get
*much* better behavior out of the remote now. Special thanks to Devin
for providing the hardware to investigate this issue.

CC: Devin Heitmueller <dheitmueller@kernellabs.com>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/media/rc/ir-raw.c