]> git.karo-electronics.de Git - linux-beck.git/commit
drm: kms_helper: don't lose hotplug event
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 5 Jun 2013 22:17:25 +0000 (00:17 +0200)
committerDave Airlie <airlied@redhat.com>
Thu, 27 Jun 2013 10:34:16 +0000 (20:34 +1000)
commit160954b7bca43da7cd3cfbce310e6df919a8216e
treec10b295d21363961641e452a92bb8179e05106f0
parent2b54f78190a2683f48f1295a4c28e98df042546a
drm: kms_helper: don't lose hotplug event

There's a race window (small for hpd, 10s large for polled outputs)
where userspace could sneak in with an unrelated connnector probe
ioctl call and eat the hotplug event (since neither the hpd nor the
poll code see a state change).

To avoid this, check whether the connector state changes in all other
->detect calls (in the current helper code that's only probe_single)
and if that's the case, fire off a hotplug event. Note that we can't
directly call the hotplug event handler, since that expects that no
locks are held (due to reentrancy with the fb code to update the kms
console).

Also, this requires that drivers using the probe_single helper
function set up the poll work. All current drivers do that already,
and with the reworked hpd handling there'll be no downside to
unconditionally setting up the poll work any more.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/drm_crtc_helper.c
include/drm/drm_crtc.h