]> git.karo-electronics.de Git - karo-tx-linux.git/commit
oom: fix the unsafe usage of badness() in proc_oom_score()
authorOleg Nesterov <oleg@redhat.com>
Thu, 1 Apr 2010 13:13:57 +0000 (15:13 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 26 Apr 2010 14:47:46 +0000 (07:47 -0700)
commit1628711eab4c0e5b82416b609e38e67a92006c13
tree5ec9200be42715ba3c4a6c94cfbc81086a89f642
parent898b5ece63b796443073f505a4403a35906f1b0b
oom: fix the unsafe usage of badness() in proc_oom_score()

commit b95c35e76b29ba812e5dabdd91592e25ec640e93 upstream.

proc_oom_score(task) has a reference to task_struct, but that is all.
If this task was already released before we take tasklist_lock

- we can't use task->group_leader, it points to nowhere

- it is not safe to call badness() even if this task is
  ->group_leader, has_intersects_mems_allowed() assumes
  it is safe to iterate over ->thread_group list.

- even worse, badness() can hit ->signal == NULL

Add the pid_alive() check to ensure __unhash_process() was not called.

Also, use "task" instead of task->group_leader. badness() should return
the same result for any sub-thread. Currently this is not true, but
this should be changed anyway.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/proc/base.c