]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ecryptfs: read on a directory should return EISDIR if not supported
authorAndy Whitcroft <apw@canonical.com>
Wed, 16 Feb 2011 04:49:59 +0000 (04:49 +0000)
committerWilly Tarreau <w@1wt.eu>
Sat, 17 Mar 2012 13:03:56 +0000 (14:03 +0100)
commit1663b5e456b6dc59d02224f93bd36d4580b94dd5
treeb7e4dfe2c49b8c2cc489eaa13b5341b992048866
parent63543d09044162d59381ca5ffd6dcf6f1d207e2f
ecryptfs: read on a directory should return EISDIR if not supported

commit 323ef68faf1bbd9b1e66aea268fd09d358d7e8ab upstream.

read() calls against a file descriptor connected to a directory are
incorrectly returning EINVAL rather than EISDIR:

  [EISDIR]
    [XSI] [Option Start] The fildes argument refers to a directory and the
    implementation does not allow the directory to be read using read()
    or pread(). The readdir() function should be used instead. [Option End]

This occurs because we do not have a .read operation defined for
ecryptfs directories.  Connect this up to generic_read_dir().

BugLink: http://bugs.launchpad.net/bugs/719691
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
fs/ecryptfs/file.c