]> git.karo-electronics.de Git - linux-beck.git/commit
cpufreq: Avoid using inactive policies
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 18 Nov 2016 12:40:45 +0000 (13:40 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 21 Nov 2016 13:35:42 +0000 (14:35 +0100)
commit182e36af0663a1050c42d234a5bf36f084f8c28b
tree9086484c063bb504ae0c56925ab3ceb192922581
parent001c76f05b01cc8ceb2098c9ff5de2609bec7f76
cpufreq: Avoid using inactive policies

There are two places in the cpufreq core in which low-level driver
callbacks may be invoked for an inactive cpufreq policy, which isn't
guaranteed to work in general.  Both are due to possible races with
CPU offline.

First, in cpufreq_get(), the policy may become inactive after
the check against policy->cpus in cpufreq_cpu_get() and before
policy->rwsem is acquired, in which case using it going forward may
not be correct.

Second, an analogous situation is possible in cpufreq_update_policy().

Avoid using inactive policies by adding policy_is_inactive() checks
to the code in the above places.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/cpufreq.c