]> git.karo-electronics.de Git - mv-sheeva.git/commit
powerpc/cell: Add of_node_put to avoid memory leak
authorJulia Lawall <julia@diku.dk>
Sat, 28 Aug 2010 23:52:46 +0000 (23:52 +0000)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Thu, 2 Sep 2010 04:07:33 +0000 (14:07 +1000)
commit182f30e4b9f6e26d565eb432d1140a487c64fa17
tree7b5c744b30b10c18d88378a24a753eaf3f84d224
parent0373721b19217c85c8c9435b79f0bac88fec9f26
powerpc/cell: Add of_node_put to avoid memory leak

Add calls to of_node_put in the error handling code following calls to
of_find_node_by_path and of_find_node_by_phandle.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
local idexpression x;
expression E,E1;
statement S;
@@

*x =
(of_find_node_by_path
|of_find_node_by_name
|of_find_node_by_phandle
|of_get_parent
|of_get_next_parent
|of_get_next_child
|of_find_compatible_node
|of_match_node
)(...);
...
if (x == NULL) S
<... when != x = E
*if (...) {
  ... when != of_node_put(x)
      when != if (...) { ... of_node_put(x); ... }
(
  return <+...x...+>;
|
*  return ...;
)
}
...>
of_node_put(x);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/platforms/cell/ras.c
arch/powerpc/platforms/cell/spider-pic.c