]> git.karo-electronics.de Git - linux-beck.git/commit
dm thin: fix race condition when destroying thin pool workqueue
authorNikolay Borisov <kernel@kyup.com>
Thu, 17 Dec 2015 16:03:35 +0000 (18:03 +0200)
committerMike Snitzer <snitzer@redhat.com>
Thu, 17 Dec 2015 20:47:20 +0000 (15:47 -0500)
commit18d03e8c25f173f4107a40d0b8c24defb6ed69f3
tree6cdaea8c63311344d76035ec82320fd337c71d6f
parent512167788a6fe9481a33a3cce5f80b684631a1bb
dm thin: fix race condition when destroying thin pool workqueue

When a thin pool is being destroyed delayed work items are
cancelled using cancel_delayed_work(), which doesn't guarantee that on
return the delayed item isn't running.  This can cause the work item to
requeue itself on an already destroyed workqueue.  Fix this by using
cancel_delayed_work_sync() which guarantees that on return the work item
is not running anymore.

Fixes: 905e51b39a555 ("dm thin: commit outstanding data every second")
Fixes: 85ad643b7e7e5 ("dm thin: add timeout to stop out-of-data-space mode holding IO forever")
Signed-off-by: Nikolay Borisov <kernel@kyup.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
drivers/md/dm-thin.c