]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mm, thp: move invariant bug check out of loop in __split_huge_page_map
authorWaiman Long <Waiman.Long@hp.com>
Thu, 26 Jun 2014 00:42:35 +0000 (10:42 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 26 Jun 2014 00:42:35 +0000 (10:42 +1000)
commit192d7878bbc2fa6b227853a996f2c18936209ca9
tree4b70630f5a301c511eebce5bd70eed3aef1924f6
parent59267a5d4f781888d31c61b4c5b5fd7460b5612b
mm, thp: move invariant bug check out of loop in __split_huge_page_map

In __split_huge_page_map(), the check for page_mapcount(page) is invariant
within the for loop.  Because of the fact that the macro is implemented
using atomic_read(), the redundant check cannot be optimized away by the
compiler leading to unnecessary read to the page structure.

This patch moves the invariant bug check out of the loop so that it will
be done only once.  On a 3.16-rc1 based kernel, the execution time of a
microbenchmark that broke up 1000 transparent huge pages using munmap()
had an execution time of 38,245us and 38,548us with and without the patch
respectively.  The performance gain is about 1%.

Signed-off-by: Waiman Long <Waiman.Long@hp.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Rik van Riel <riel@redhat.com>
Cc: Scott J Norton <scott.norton@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/huge_memory.c