]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mmc: sdricoh_cs: Less checks in sdricoh_init_mmc() after, error detection
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 29 Dec 2015 20:45:34 +0000 (21:45 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 2 Feb 2016 12:44:04 +0000 (13:44 +0100)
commit1aec611c37035567f7526df4a5c33641b4b90909
tree025877a4a392770e7ba074ee33fd7067c2438d32
parent62818de4c1b490adf00cd22cd76035b8ffe2e5aa
mmc: sdricoh_cs: Less checks in sdricoh_init_mmc() after, error detection

This issue was detected by using the Coccinelle software.

Two pointer checks could be repeated by the sdricoh_init_mmc() function
during error handling even if the relevant properties can be determined
for the involved variables before by source code analysis.

* This implementation detail could be improved by adjustments
  for jump targets according to the Linux coding style convention.

* Drop an unnecessary initialisation for the variable "mmc" then.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdricoh_cs.c