]> git.karo-electronics.de Git - linux-beck.git/commit
ratelimit: fix WARN_ON_RATELIMIT return value
authorJiri Slaby <jslaby@suse.cz>
Tue, 20 Dec 2016 00:23:12 +0000 (16:23 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 20 Dec 2016 17:48:47 +0000 (09:48 -0800)
commit1b011e2f13fcf37e1e577fed25b295808d6c83b9
tree50bb2b58757f3c578f40dec19c2b42a8d6bc534d
parent4983f0ab7ffaad1e534b21975367429736475205
ratelimit: fix WARN_ON_RATELIMIT return value

The macro is to be used similarly as WARN_ON as:

  if (WARN_ON_RATELIMIT(condition, state))
do_something();

One would expect only 'condition' to affect the 'if', but
WARN_ON_RATELIMIT does internally only:

  WARN_ON((condition) && __ratelimit(state))

So the 'if' is affected by the ratelimiting state too.  Fix this by
returning 'condition' in any case.

Note that nobody uses WARN_ON_RATELIMIT yet, so there is nothing to
worry about.  But I was about to use it and was a bit surprised.

Link: http://lkml.kernel.org/r/20161215093224.23126-1-jslaby@suse.cz
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/ratelimit.h