]> git.karo-electronics.de Git - linux-beck.git/commit
Staging: wlan-ng: memsetting the wrong amount of data
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 21 Feb 2012 14:18:38 +0000 (17:18 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Feb 2012 20:03:13 +0000 (12:03 -0800)
commit1ca1a92cc6d337a149d1e37d4ab0db8ad45b0fde
treea058acb43f83a0cf1d63425db49fc5a152a819d0
parentd8aa3e26f48cf42ef8cf74cedd50e6961b10ff54
Staging: wlan-ng: memsetting the wrong amount of data

p80211item_pstr6_t is the size of "msg1.bssid" (16 bytes) but
msg1.bssid.data is type p80211pstr6_t and it is smaller (7 bytes).  We
had just set that memory to zeroes earlier and now we're writing over it
with 0xff because we're writing past the end of the struct.

I don't know if this actually causes a problem.  It may be that we
initialize the extra 0xff bytes correctly later.  But the current code
is obviously wrong and we should fix it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wlan-ng/cfg80211.c