]> git.karo-electronics.de Git - karo-tx-linux.git/commit
spi: omap2_mcspi PIO RX fix
authorKalle Valo <kalle.valo@nokia.com>
Thu, 24 Jan 2008 22:00:40 +0000 (14:00 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 8 Feb 2008 20:01:47 +0000 (12:01 -0800)
commit1ce946cdae3bef836416d8ced58eab4d18c45675
treedbc9c0fef3abe77c4a39f8d66d006e3b857664d5
parent03fce1f0345c212fd835bb764d161810b0e6bdd4
spi: omap2_mcspi PIO RX fix

patch feed9bab7b14b77be8d796bcee95e2343fb82955 in mainline.

Before transmission of the last word in PIO RX_ONLY mode rx+tx mode
is enabled:

/* prevent last RX_ONLY read from triggering
 * more word i/o: switch to rx+tx
 */
if (c == 0 && tx == NULL)
mcspi_write_cs_reg(spi,
OMAP2_MCSPI_CHCONF0, l);

But because c is decremented after the test, c will never be zero and
rx+tx will not be enabled. This breaks RX_ONLY mode PIO transfers.

Fix it by decrementing c in the beginning of the various I/O loops.

Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/spi/omap2_mcspi.c