]> git.karo-electronics.de Git - linux-beck.git/commit
spi: designware: delete premature free_irq
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 2 Sep 2013 09:54:20 +0000 (11:54 +0200)
committerMark Brown <broonie@linaro.org>
Mon, 16 Sep 2013 23:19:14 +0000 (00:19 +0100)
commit1e0d191f62c779cdd6953db2541b6b92969ce1bb
tree33ff14c5b0ecc8c40d20057b6196641d80ebc9ce
parent272b98c6455f00884f0350f775c5342358ebb73f
spi: designware: delete premature free_irq

Free_irq is not needed if there has been no request_irq.  Free_irq is
removed from both the probe and remove functions.  The correct request_irq
and free_irq appear to be in the add_host and remove_host functions in
spi-dw.c.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

*e = platform_get_irq(...);
... when != request_irq(e,...)
*free_irq(e,...)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/spi/spi-dw-mmio.c