]> git.karo-electronics.de Git - karo-tx-linux.git/commit
hugetlb: detect race upon page allocation failure during COW
authorHillf Danton <dhillf@gmail.com>
Wed, 30 Nov 2011 04:11:26 +0000 (15:11 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 30 Nov 2011 04:13:47 +0000 (15:13 +1100)
commit1e49af5643d15dcd2bac310037c85b213c840c21
treee606b191fd64492bcef61b9e8213cc9400678a43
parent560777060ba78645883fe3141a7efbfc03e6819b
hugetlb: detect race upon page allocation failure during COW

Currently we are not rechecking pte_same in hugetlb_cow after we take ptl
lock again in the page allocation failure code path and simply retry
again.  This is not an issue at the moment because hugetlb fault path is
protected by hugetlb_instantiation_mutex so we cannot race.

The original page is locked and so we cannot race even with the page
migration.

Let's add the pte_same check anyway as we want to be consistent with the
other check later in this function and be safe if we ever remove the
mutex.

[mhocko@suse.cz: reworded the changelog]
Signed-off-by: Hillf Danton <dhillf@gmail.com>
Signed-off-by: Michal Hocko <mhocko@suse.cz>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Johannes Weiner <jweiner@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/hugetlb.c