]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ocfs2: Release buffer_head in case of error in ocfs2_double_lock.
authorTao Ma <boyu.mt@taobao.com>
Mon, 20 Dec 2010 08:21:11 +0000 (16:21 +0800)
committerJoel Becker <joel.becker@oracle.com>
Thu, 23 Dec 2010 02:34:42 +0000 (18:34 -0800)
commit1e6d9153df27923649976554d034a69ac7b28f95
treedfb165957114d9cd6afd1ddbc316ff65d001bed1
parentcfc069d3fa24d7c6357e3b731e97f94db495bf0c
ocfs2: Release buffer_head in case of error in ocfs2_double_lock.

In ocfs2_double_lock, when ocfs2_inode_lock for inode1 fails, we
just unlock inode2 and return without releasing buffer we get from
inode_lock(inode2). The good thing is that it is freed by the only
caller ocfs2_rename when it exits.

But I don't think this is a right way for error handling. We should
free the buffer_head we get in ocfs2_double_lock before exit so that
the caller doesn't need to take care of it.

Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
fs/ocfs2/namei.c