]> git.karo-electronics.de Git - linux-beck.git/commit
tpm atmel: Call request_region with the correct base
authorJason Gunthorpe <jgunthorpe@obsidianresearch.com>
Sat, 14 Sep 2013 23:36:29 +0000 (17:36 -0600)
committerPeter Huewe <peterhuewe@gmx.de>
Tue, 22 Oct 2013 17:42:26 +0000 (19:42 +0200)
commit1e6e0974b5d401ab8505eca821f00fcb74d50a55
tree4788313b381de2ec3ab356068297ec04cae34800
parent37ab03414829e5cf261d7f82f0a39b505635143e
tpm atmel: Call request_region with the correct base

Commit e0dd03caf20d040a0a86 ("tpm: return chip from
tpm_register_hardware") changed the code path here so that
ateml_get_base_addr no longer directly altered the tpm_vendor_specific
structure, and instead placed the base address on the stack.

The commit missed updating the request_region call, which would have
resulted in request_region being called with 0 as the base address.

I don't know if request_region(0, ..) will fail, if so the
driver has been broken since 2006 and we should remove it
from the tree as it has no users.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Reviewed-by: Joel Schopp <jschopp@linux.vnet.ibm.com>
Reviewed-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
drivers/char/tpm/tpm_atmel.c