]> git.karo-electronics.de Git - karo-tx-linux.git/commit
clean up scary strncpy(dst, src, strlen(src)) uses
authorKees Cook <keescook@chromium.org>
Fri, 7 Jun 2013 00:08:37 +0000 (10:08 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Fri, 7 Jun 2013 05:42:40 +0000 (15:42 +1000)
commit1e9642ada02bb9c39257ad3bddf4b460c29a97ce
treed304e44aa335de6a7f9e435f803dd748902daf38
parent881f3cf30cef4081d577d35d85cab07b27507c09
clean up scary strncpy(dst, src, strlen(src)) uses

Fix various weird constructions of strncpy(dst, src, strlen(src)).  Length
limits should be about the space available in the destination, not
repurposed as a method to either always include or always exclude a
trailing NULL byte.  Either the NULL should always be copied (using
strlcpy), or it should not be copied (using something like memcpy).
Readable code should not depend on the weird behavior of strncpy when it
hits the length limit.  Better to avoid the anti-pattern entirely.

Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> [staging]
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> [acpi]
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Ursula Braun <ursula.braun@de.ibm.com>
Cc: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Cc: Richard Weinberger <richard@nod.at>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Documentation/accounting/getdelays.c
drivers/acpi/sysfs.c
drivers/s390/net/qeth_l3_sys.c
drivers/staging/tidspbridge/rmgr/drv_interface.c
fs/hppfs/hppfs.c