]> git.karo-electronics.de Git - linux-beck.git/commit
[CPUFREQ] cpumask: avoid playing with cpus_allowed in powernow-k8.c
authorRusty Russell <rusty@rustcorp.com.au>
Fri, 12 Jun 2009 11:25:37 +0000 (20:55 +0930)
committerDave Jones <davej@redhat.com>
Mon, 15 Jun 2009 15:49:43 +0000 (11:49 -0400)
commit1ff6e97f1d993dff2f9b6f4a9173687370660232
tree19cadec61f22a61a0e4c2d338ccd8672710aed17
parente3f996c26ff6c4c084aaaa64dce6e54d31f517be
[CPUFREQ] cpumask: avoid playing with cpus_allowed in powernow-k8.c

cpumask: avoid playing with cpus_allowed in powernow-k8.c

It's generally a very bad idea to mug some process's cpumask: it could
legitimately and reasonably be changed by root, which could break us
(if done before our code) or them (if we restore the wrong value).

I did not replace powernowk8_target; it needs fixing, but it grabs a
mutex (so no smp_call_function_single here) but Mark points out it can
be called multiple times per second, so work_on_cpu is too heavy.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
To: cpufreq@vger.kernel.org
Acked-by: Mark Langsdorf <mark.langsdorf@amd.com>
Tested-by: Mark Langsdorf <mark.langsdorf@amd.com>
Signed-off-by: Dave Jones <davej@redhat.com>
arch/x86/kernel/cpu/cpufreq/powernow-k8.c