]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ext4: remove erroneous ext4_superblock_csum_set() in update_backups()
authorTao Ma <boyu.mt@taobao.com>
Thu, 20 Sep 2012 15:35:38 +0000 (11:35 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 20 Sep 2012 15:35:38 +0000 (11:35 -0400)
commit21a75ef00fab2aa5bdfeb6d2402d9461031041e3
treeab2a7ae706dde29c7cc741289e9c31fc5c0aaec4
parent40e684e5c597a98996cf4616e31fb2581ec82060
ext4: remove erroneous ext4_superblock_csum_set() in update_backups()

The update_backups() function is used to backup all the metadata
blocks, so we should not take it for granted that 'data' is pointed to
a super block and use ext4_superblock_csum_set to calculate the
checksum there.  In case where the data is a group descriptor block,
it will corrupt the last group descriptor, and then e2fsck will
complain about it it.

As all the metadata checksums should already be OK when we do the
backup, remove the wrong ext4_superblock_csum_set and it should be
just fine.

Reported-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
fs/ext4/resize.c