]> git.karo-electronics.de Git - karo-tx-linux.git/commit
libceph: only kunmap kmapped pages
authorAlex Elder <elder@inktank.com>
Fri, 21 Sep 2012 22:59:58 +0000 (17:59 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 26 Nov 2012 19:38:43 +0000 (11:38 -0800)
commit21e292e34c48c03fb6638c2d1295ca12dac97b03
treeba7de4f8fdac94c211b946544cd6a35cf9bd74e0
parent76cb69279f83889cf98fd9f16f5d50bcc2779442
libceph: only kunmap kmapped pages

(cherry picked from commit 5ce765a540f34d1e2005e1210f49f67fdf11e997)

In write_partial_msg_pages(), pages need to be kmapped in order to
perform a CRC-32c calculation on them.  As an artifact of the way
this code used to be structured, the kunmap() call was separated
from the kmap() call and both were done conditionally.  But the
conditions under which the kmap() and kunmap() calls were made
differed, so there was a chance a kunmap() call would be done on a
page that had not been mapped.

The symptom of this was tripping a BUG() in kunmap_high() when
pkmap_count[nr] became 0.

Reported-by: Bryan K. Wright <bryan@virginia.edu>
Signed-off-by: Alex Elder <elder@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ceph/messenger.c