]> git.karo-electronics.de Git - karo-tx-linux.git/commit
x25: Validate incoming call user data lengths
authorMatthew Daley <mattjd@gmail.com>
Tue, 19 Mar 2013 11:36:47 +0000 (12:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Apr 2013 17:16:37 +0000 (10:16 -0700)
commit21f9f5219401be3815db41e60072a53dadf828b6
treed675922b71de29cbcdb465ccaa6357a1dc80b7b3
parentd104388ff9bdb5ec76d5337cd94f9ed4bbf73fbc
x25: Validate incoming call user data lengths

commit c7fd0d48bde943e228e9c28ce971a22d6a1744c4 upstream.

X.25 call user data is being copied in its entirety from incoming messages
without consideration to the size of the destination buffers, leading to
possible buffer overflows. Validate incoming call user data lengths before
these copies are performed.

It appears this issue was noticed some time ago, however nothing seemed to
come of it: see http://www.spinics.net/lists/linux-x25/msg00043.html and
commit 8db09f26f912f7c90c764806e804b558da520d4f.

Signed-off-by: Matthew Daley <mattjd@gmail.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Andrew Hendry <andrew.hendry@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/x25/af_x25.c
net/x25/x25_in.c