]> git.karo-electronics.de Git - karo-tx-linux.git/commit
arp_notify: unconditionally send gratuitous ARP for NETDEV_NOTIFY_PEERS.
authorIan Campbell <Ian.Campbell@citrix.com>
Fri, 11 Feb 2011 07:44:16 +0000 (07:44 +0000)
committerAK <andi@firstfloor.org>
Thu, 31 Mar 2011 18:58:18 +0000 (11:58 -0700)
commit23816cabbcac4826dd62590edeb0518e318217a7
tree02842ff060c84ec3763ee8b7efb36601b02c1d16
parent7e150642300a8c69f3e219f960f0d454ca442df8
arp_notify: unconditionally send gratuitous ARP for NETDEV_NOTIFY_PEERS.

commit d11327ad6695db8117c78d70611e71102ceec2ac upstream.

NETDEV_NOTIFY_PEER is an explicit request by the driver to send a link
notification while NETDEV_UP/NETDEV_CHANGEADDR generate link
notifications as a sort of side effect.

In the later cases the sysctl option is present because link
notification events can have undesired effects e.g. if the link is
flapping. I don't think this applies in the case of an explicit
request from a driver.

This patch makes NETDEV_NOTIFY_PEER unconditional, if preferred we
could add a new sysctl for this case which defaults to on.

This change causes Xen post-migration ARP notifications (which cause
switches to relearn their MAC tables etc) to be sent by default.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
[reported to solve hyperv live migration problem - gkh]
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Mike Surcouf <mike@surcouf.co.uk>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/ipv4/devinet.c