]> git.karo-electronics.de Git - linux-beck.git/commit
xtensa: ISS: fix locking in TAP network adapter
authorMax Filippov <jcmvbkbc@gmail.com>
Fri, 3 Apr 2015 06:56:21 +0000 (09:56 +0300)
committerMax Filippov <jcmvbkbc@gmail.com>
Mon, 13 Apr 2015 06:01:00 +0000 (09:01 +0300)
commit24e94454c8cb6a13634f5a2f5a01da53a546a58d
tree97428ea550eb6c74ed239c3e2efd94369d9734e5
parent39a8804455fb23f09157341d3ba7db6d7ae6ee76
xtensa: ISS: fix locking in TAP network adapter

- don't lock lp->lock in the iss_net_timer for the call of iss_net_poll,
  it will lock it itself;
- invert order of lp->lock and opened_lock acquisition in the
  iss_net_open to make it consistent with iss_net_poll;
- replace spin_lock with spin_lock_bh when acquiring locks used in
  iss_net_timer from non-atomic context;
- replace spin_lock_irqsave with spin_lock_bh in the iss_net_start_xmit
  as the driver doesn't use lp->lock in the hard IRQ context;
- replace __SPIN_LOCK_UNLOCKED(lp.lock) with spin_lock_init, otherwise
  lockdep is unhappy about using non-static key.

Cc: <stable@vger.kernel.org>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
arch/xtensa/platforms/iss/network.c