]> git.karo-electronics.de Git - karo-tx-linux.git/commit
hostap_cs: fix sleeping function called from invalid context
authorStanislaw Gruszka <sgruszka@redhat.com>
Mon, 10 Jan 2011 11:56:05 +0000 (12:56 +0100)
committerWilly Tarreau <w@1wt.eu>
Sat, 30 Apr 2011 14:53:01 +0000 (16:53 +0200)
commit25af68e330ba7d6f65394fcf3660000c892ec2e4
tree835aa93f329263f3fe2987559ff2666327db843f
parent301b5f90652ce4b241459df0568d9f7634d1f693
hostap_cs: fix sleeping function called from invalid context

commit 4e5518ca53be29c1ec3c00089c97bef36bfed515 upstream.

pcmcia_request_irq() and pcmcia_enable_device() are intended
to be called from process context (first function allocate memory
with GFP_KERNEL, second take a mutex). We can not take spin lock
and call them.

It's safe to move spin lock after pcmcia_enable_device() as we
still hold off IRQ until dev->base_addr is 0 and driver will
not proceed with interrupts when is not ready.

Patch resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=643758

Reported-and-tested-by: rbugz@biobind.com
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/wireless/hostap/hostap_cs.c