]> git.karo-electronics.de Git - karo-tx-linux.git/commit
tpm_tis: Check return values from get_burstcount.
authorJosh Zimmerman <joshz@google.com>
Thu, 27 Oct 2016 21:50:09 +0000 (14:50 -0700)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Sun, 27 Nov 2016 23:31:30 +0000 (01:31 +0200)
commit26a137e31ffe6fbfdb008554a8d9b3d55bd5c86e
treed219a64c584e644ae910aa2979d13fe95a43afbe
parentca6d45802201c2680af040579af7697049149e38
tpm_tis: Check return values from get_burstcount.

If the TPM we're connecting to uses a static burst count, it will report
a burst count of zero throughout the response read. However, get_burstcount
assumes that a response of zero indicates that the TPM is not ready to
receive more data. In this case, it returns a negative error code, which
is passed on to tpm_tis_{write,read}_bytes as a u16, causing
them to read/write far too many bytes.

This patch checks for negative return codes and bails out from recv_data
and tpm_tis_send_data.

Cc: stable@vger.kernel.org
Fixes: 1107d065fdf1 (tpm_tis: Introduce intermediate layer for TPM access)
Signed-off-by: Josh Zimmerman <joshz@google.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
drivers/char/tpm/tpm_tis_core.c