]> git.karo-electronics.de Git - karo-tx-linux.git/commit
ncr5380: Remove NCR5380_STATS
authorFinn Thain <fthain@telegraphics.com.au>
Wed, 12 Nov 2014 05:11:57 +0000 (16:11 +1100)
committerChristoph Hellwig <hch@lst.de>
Thu, 20 Nov 2014 08:11:07 +0000 (09:11 +0100)
commit270ac2c290ad8b83c92ceeed07aaf49ec5807851
tree0dabf1e56da98f3cf1432620702631c6e997309a
parent22f5f10d2dadc50bf26a482b782a5e04f6e9b362
ncr5380: Remove NCR5380_STATS

The NCR5380_STATS option is only enabled by g_NCR5380 yet it adds
clutter to all three core drivers. The atari_NCR5380.c and sun3_NCR5380.c
core drivers have a slightly different implementation of the
NCR5380_STATS option.

Out of all ten NCR5380 drivers, only one of them (g_NCR5380) actually
has the code to report on the collected stats. Aside from being unreadable,
that code seems to be broken because there's no initialization of timebase.
sun3_NCR5380.c and atari_NCR5380.c have the timebase initialization but
lack the code to report the stats.

Remove all of this code to improve readability and reduce divergence
between the three core drivers.

This patch and the next one completely eliminate the PRINTP and ANDP
pre-processor abuse.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/NCR5380.c
drivers/scsi/NCR5380.h
drivers/scsi/atari_NCR5380.c
drivers/scsi/g_NCR5380.c
drivers/scsi/sun3_NCR5380.c