]> git.karo-electronics.de Git - karo-tx-linux.git/commit
gro: Reset dev pointer on reuse
authorHerbert Xu <herbert@gondor.apana.org.au>
Sun, 30 Jan 2011 04:44:54 +0000 (20:44 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 14 Apr 2011 23:53:40 +0000 (16:53 -0700)
commit2863e5a77bfad29694be0d72b965503de3fddb8d
tree77c0b12d77a08eb9612de75fdaf1a93ca413eefc
parent79760cb772e9b80bac911c78caed52c7921f1bce
gro: Reset dev pointer on reuse

commit 66c46d741e2e60f0e8b625b80edb0ab820c46d7a upstream.

On older kernels the VLAN code may zero skb->dev before dropping
it and causing it to be reused by GRO.

Unfortunately we didn't reset skb->dev in that case which causes
the next GRO user to get a bogus skb->dev pointer.

This particular problem no longer happens with the current upstream
kernel due to changes in VLAN processing.

However, for correctness we should still reset the skb->dev pointer
in the GRO reuse function in case a future user does the same thing.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Brandon Philips <bphilips@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/core/dev.c