]> git.karo-electronics.de Git - karo-tx-linux.git/commit
xhci: Fix potential NULL ptr deref in command cancellation.
authorSarah Sharp <sarah.a.sharp@linux.intel.com>
Tue, 16 Oct 2012 20:17:43 +0000 (13:17 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Oct 2012 17:09:58 +0000 (10:09 -0700)
commit288a8f85227007e326758197a3ad7cd56d66e3e3
tree9ce6adee68d8c94b768cc56b35d8446567956fe6
parentcb499284d1cf7de50b85fcfb3248bae2db090d14
xhci: Fix potential NULL ptr deref in command cancellation.

commit 43a09f7fb01fa1e091416a2aa49b6c666458c1ee upstream.

The command cancellation code doesn't check whether find_trb_seg()
couldn't find the segment that contains the TRB to be canceled.  This
could cause a NULL pointer deference later in the function when next_trb
is called.  It's unlikely to happen unless something is wrong with the
command ring pointers, so add some debugging in case it happens.

This patch should be backported to stable kernels as old as 3.0, that
contain the commit b63f4053cc8aa22a98e3f9a97845afe6c15d0a0d "xHCI:
handle command after aborting the command ring".

Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-ring.c