]> git.karo-electronics.de Git - karo-tx-linux.git/commit
rcu: Fix batch-limit size problem
authorEric Dumazet <edumazet@google.com>
Thu, 18 Oct 2012 11:55:36 +0000 (04:55 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2012 18:37:46 +0000 (10:37 -0800)
commit29251de53e1712158c29b3626a008d8b93a6e024
treeacbbbf18020a71fd5d01beba87453b70fc24b989
parentd5a79aa30b7e6cd68dfee6a76acbe6c7f7905f51
rcu: Fix batch-limit size problem

commit 878d7439d0f45a95869e417576774673d1fa243f upstream.

Commit 29c00b4a1d9e27 (rcu: Add event-tracing for RCU callback
invocation) added a regression in rcu_do_batch()

Under stress, RCU is supposed to allow to process all items in queue,
instead of a batch of 10 items (blimit), but an integer overflow makes
the effective limit being 1.  So, unless there is frequent idle periods
(during which RCU ignores batch limits), RCU can be forced into a
state where it cannot keep up with the callback-generation rate,
eventually resulting in OOM.

This commit therefore converts a few variables in rcu_do_batch() from
int to long to fix this problem, along with the module parameters
controlling the batch limits.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/rcutree.c