]> git.karo-electronics.de Git - karo-tx-linux.git/commit
st: fix race in st_scsi_execute_end
authorPetr Uzel <petr.uzel@suse.cz>
Fri, 21 Oct 2011 11:31:09 +0000 (13:31 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 11 Nov 2011 17:37:01 +0000 (09:37 -0800)
commit292b3893b8e010398a338b482f40cbcd62e01a97
tree4cdc3e26e5dc1d41d5bfb8c0537c60ad0b33f424
parentfef547148349098f58bcea1c6cda5be1f6f8719c
st: fix race in st_scsi_execute_end

commit c68bf8eeaa57c852e74adcf597237be149eef830 upstream.

The call to complete() in st_scsi_execute_end() wakes up sleeping thread
in write_behind_check(), which frees the st_request, thus invalidating
the pointer to the associated bio structure, which is then passed to the
blk_rq_unmap_user(). Fix by storing pointer to bio structure into
temporary local variable.

This bug is present since at least linux-2.6.32.

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>
Reported-by: Juergen Groß <juergen.gross@ts.fujitsu.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/st.c