]> git.karo-electronics.de Git - karo-tx-linux.git/commit
locks: fix checking of fcntl_setlease argument
authorJ. Bruce Fields <bfields@fieldses.org>
Mon, 23 Jul 2012 19:17:17 +0000 (15:17 -0400)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 2 Aug 2012 13:37:59 +0000 (14:37 +0100)
commit295cc2b91b078eb04f42db40ee04788c685dd351
treebeb2ae21c253fa8e57e484282a34f4ae4ddc8928
parentad15432068b43135d7af36e555c9d48b0d37c3c3
locks: fix checking of fcntl_setlease argument

commit 0ec4f431eb56d633da3a55da67d5c4b88886ccc7 upstream.

The only checks of the long argument passed to fcntl(fd,F_SETLEASE,.)
are done after converting the long to an int.  Thus some illegal values
may be let through and cause problems in later code.

[ They actually *don't* cause problems in mainline, as of Dave Jones's
  commit 8d657eb3b438 "Remove easily user-triggerable BUG from
  generic_setlease", but we should fix this anyway.  And this patch will
  be necessary to fix real bugs on earlier kernels. ]

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
fs/locks.c