]> git.karo-electronics.de Git - linux-beck.git/commit
staging: comedi: s526: cleanup s526_gpct_rinsn()
authorH Hartley Sweeten <hartleys@visionengravers.com>
Wed, 19 Sep 2012 22:12:01 +0000 (15:12 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Sep 2012 16:19:44 +0000 (09:19 -0700)
commit2a29edf69807a43ad7594554cea4def755443103
tree173f421b443561de7d1630f33f345cd62dff618e
parent43a352760e6c1c073c12f6e21d02b789525e677e
staging: comedi: s526: cleanup s526_gpct_rinsn()

Use a local variable for the iobase of the channel being read.
This makes the inw() calls a bit cleaner.

Move the masking of the read data to make the value stored in
the data array a bit clearer.

The comedi core expects insn_read functions to return the number
of insn data values read. For this function, the final value of
'i' is correct but change the return to 'insn->n' just to make
it clear.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/s526.c