]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Allocate correct size (portably) in drivers/usb/gadget/f_midi.c::f_midi_bind()
authorJesper Juhl <jj@chaosbits.net>
Thu, 1 Mar 2012 22:01:19 +0000 (23:01 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Mar 2012 00:22:11 +0000 (16:22 -0800)
commit2a5be8783e0016d15e7907ddd212b2c312e196eb
tree400f52423b5fbd7d94f7bbe4925a4a59103e96eb
parentb1443ac0e486842c133b8805ee035ab3ff918763
Allocate correct size (portably) in drivers/usb/gadget/f_midi.c::f_midi_bind()

As the coverity checker puts it:

"Passing argument "sizeof (midi_function) /*8*/" to function "kcalloc"
and then casting the return value to "struct usb_descriptor_header **"
is suspicious. ... In this particular case sizeof(struct
usb_descriptor_header **) happens to be equal to sizeof(struct
usb_descriptor_header *), but this is not a portable assumption."

I believe we really do intend to use 'sizeof(*midi_function)' here, so
this patch makes that change.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/f_midi.c