]> git.karo-electronics.de Git - linux-beck.git/commit
Staging: easycap: fix sparse warnings for module parameters
authorTomas Winkler <tomas.winkler@intel.com>
Tue, 18 Jan 2011 12:03:23 +0000 (14:03 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 21 Jan 2011 20:27:19 +0000 (12:27 -0800)
commit2a9a05c43294d703e351753da49231c47e0aad0d
treef43776db5f6a6c8482f895f464e823440fb17f49
parenta9855917290fc40dbfd67d3ee06c190667d6c5b5
Staging: easycap: fix sparse warnings for module parameters

easycap_main.c:34:5: warning: symbol 'easycap_debug' was not declared. Should it be static?
easycap_main.c:36:5: warning: symbol 'easycap_gain' was not declared. Should it be static?

These two variables actually were declared in several places.
The variables are used in several files.
I've fixed "easycap_debug" so it gets declared in one place only and included properly.
For "easycap_gain" made it static and I created added a
->gain member to the easycap struct.  This seems cleaner than using a
global variable and later on we may make this controlable via sysfs.

Cc:Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/easycap/easycap.h
drivers/staging/easycap/easycap_ioctl.h
drivers/staging/easycap/easycap_low.c
drivers/staging/easycap/easycap_low.h
drivers/staging/easycap/easycap_main.c
drivers/staging/easycap/easycap_settings.h
drivers/staging/easycap/easycap_sound.h
drivers/staging/easycap/easycap_testcard.h