]> git.karo-electronics.de Git - karo-tx-linux.git/commit
Staging: dream: introduce missing kfree
authorJulia Lawall <julia@diku.dk>
Fri, 11 Sep 2009 16:22:27 +0000 (18:22 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 15 Sep 2009 19:02:34 +0000 (12:02 -0700)
commit2bb6a12a88aeac9bab4ed0cf0da1edc03f5eb686
tree7d81f9c9d2208af2df80c7fe2d5241c757d40a3f
parenta2279ae5b58edb7cbe2196d08572fcf59f292354
Staging: dream: introduce missing kfree

Error handling code following a kmalloc or kzalloc should free the
allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
drivers/staging/dream/camera/msm_v4l2.c
drivers/staging/dream/camera/msm_vfe8x_proc.c