]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mm/msync.c: sync only the requested range in msync()
authorMatthew Wilcox <matthew.r.wilcox@intel.com>
Thu, 22 May 2014 00:43:26 +0000 (10:43 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 22 May 2014 00:43:26 +0000 (10:43 +1000)
commit2ca02863fa2e76f23fef3bcfbdf5ed7e94501474
tree3af71c96ee5b7ba6e577188549772c73a3373646
parentdb6b6837d8f338586e0ab13727d5cffedbee97de
mm/msync.c: sync only the requested range in msync()

msync() currently syncs more than POSIX requires or BSD or Solaris
implement.  It is supposed to be equivalent to fdatasync(), not fsync(),
and it is only supposed to sync the portion of the file that overlaps the
range passed to msync.

If the VMA is non-linear, fall back to syncing the entire file, but we
still optimise to only fdatasync() the entire file, not the full fsync().

akpm: there are obvious concerns with bck-compatibility: is anyone relying
on the undocumented side-effect for their data integrity?  And how would
they ever know if this change broke their data integrity?

We think the risk is reasonably low, and this patch brings the kernel into
line with other OS's and with what the manpage has always said...

Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Cc: Chris Mason <clm@fb.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/msync.c