]> git.karo-electronics.de Git - linux-beck.git/commit
greybus: connection: switch to using spin_lock_irqsave/spin_lock_irqrestore excluisvely
authorJeffrey Carlyle <jcarlyle@google.com>
Fri, 24 Jun 2016 03:28:56 +0000 (08:58 +0530)
committerGreg Kroah-Hartman <gregkh@google.com>
Fri, 24 Jun 2016 23:06:23 +0000 (16:06 -0700)
commit2d466c23c64f7556d0a184a1f02b2c8a23edaf5e
tree5aff4fe579f0035d1be7cc33d1fedee7cbc36b0a
parent326f98ac3168cf415f4e1681b3684614bcd79fd3
greybus: connection: switch to using spin_lock_irqsave/spin_lock_irqrestore excluisvely

We know that it is a bad idea to explicitly enable IRQs when we don't
don't know if they were already off before we disabled, so switch to the
save _irqsave and _irqrestore functions.

Ultimately, we need to review places in the Greybus drivers where IRQs
are disabled and remove unnecessary instances. This is only an interim
step.

This code will never run from hard irq context, as it is already taking
mutex in the path.

Testing done: booted EVT2.0, ran suspend/resume test app with a period
of 20s for a few dozen cycles.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Jeffrey Carlyle <jcarlyle@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/connection.c