]> git.karo-electronics.de Git - karo-tx-linux.git/commit
PCI/cardbus: Add a fixup hook and fix powerpc
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 19 Jan 2010 11:42:19 +0000 (12:42 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 22 Jan 2010 23:18:26 +0000 (15:18 -0800)
commit2db740cb364a38b6bf50e1c61dc6d9615bfe390c
tree070ab3b6c8ab6855268e6e873b54d965741fd74e
parenteecd8a9ec6488e6b5c43c1c12368d6fdb8aa9430
PCI/cardbus: Add a fixup hook and fix powerpc

commit 2d1c861871d767153538a77c498752b36d4bb4b8 upstream

The cardbus code creates PCI devices without ever going through the
necessary fixup bits and pieces that normal PCI devices go through.

There's in fact a commented out call to pcibios_fixup_bus() in there,
it's commented because ... it doesn't work.

I could make pcibios_fixup_bus() do the right thing on powerpc easily
but I felt it cleaner instead to provide a specific hook pci_fixup_cardbus
for which a weak empty implementation is provided by the PCI core.

This fixes cardbus on powerbooks and probably all other PowerPC
platforms which was broken completely for ever on some platforms and
since 2.6.31 on others such as PowerBooks when we made the DMA ops
mandatory (since those are setup by the fixups).

Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/powerpc/kernel/pci-common.c
drivers/pci/pci.c
drivers/pcmcia/cardbus.c
include/linux/pci.h