]> git.karo-electronics.de Git - karo-tx-linux.git/commit
sctp: set sin_port for addr param when checking duplicate address
authorXin Long <lucien.xin@gmail.com>
Fri, 24 Feb 2017 07:18:46 +0000 (15:18 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Feb 2017 02:24:05 +0000 (21:24 -0500)
commit2e3ce5bc2aa938653c3866aa7f4901a1f199b1c8
tree1d84e80e6378e68fa84d47c171d0fd1d8d504005
parent47d3a07528ecbbccf53bc4390d70b4e3d1c04fcf
sctp: set sin_port for addr param when checking duplicate address

Commit b8607805dd15 ("sctp: not copying duplicate addrs to the assoc's
bind address list") tried to check for duplicate address before copying
to asoc's bind_addr list from global addr list.

But all the addrs' sin_ports in global addr list are 0 while the addrs'
sin_ports are bp->port in asoc's bind_addr list. It means even if it's
a duplicate address, af->cmp_addr will still return 0 as the their
sin_ports are different.

This patch is to fix it by setting the sin_port for addr param with
bp->port before comparing the addrs.

Fixes: b8607805dd15 ("sctp: not copying duplicate addrs to the assoc's bind address list")
Reported-by: Wei Chen <weichen@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/protocol.c